Skip to content

ci: Enforce Chromatic as required check for design system changes (no-changelog)#2070

Open
everettbu wants to merge 1 commit intomasterfrom
shortstacked/chromatic-ci-filter
Open

ci: Enforce Chromatic as required check for design system changes (no-changelog)#2070
everettbu wants to merge 1 commit intomasterfrom
shortstacked/chromatic-ci-filter

Conversation

@everettbu
Copy link
Copy Markdown

Mirror of n8n-io/n8n#26126
Original author: shortstacked


Summary

  • Add design-system filter to ci-filter in the PR workflow, matching changes in @n8n`/design-system`, @n8n/chat, ``@n8n/storybook, and the Chromatic workflow file
  • Gate a new chromatic job on that filter and include it in required-checks — skipped jobs pass validation, so only PRs touching the design system are blocked
  • Convert test-visual-chromatic.yml into a reusable callable workflow and remove the unused daily cron and pull_request_review triggers

Test plan

  • PR with design system changes → Chromatic job runs and must pass for Required Checks
  • PR without design system changes → Chromatic job is skipped, Required Checks still passes
  • Manual dispatch of test-visual-chromatic.yml still works

🤖 Generated with Claude Code

…-changelog)

Use ci-filter to conditionally run Chromatic on PRs that touch the
design system, chat, or storybook packages. Convert the Chromatic
workflow into a reusable callable workflow and remove the unused
daily cron and pull_request_review triggers.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants